404 should be returned when there is a layout but no view

vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.

https://hilla.dev

Apache License 2.0

867 stars 58 forks source link

404 should be returned when there is a layout but no view #2539

Closed Artur- closed 1 week ago

Artur- commented 3 weeks ago

Describe the bug

If you have src/main/frontend/views/@layout.tsx but no src/main/frontend/views/@index.tsx then opening / returns the layout without any contents

Expected-behavior

It should return the "route not found" page as there is no @index.tsx

Reproduction

start.vaadin.com -> new project -> download -> run

System Info

24.4.1

platosha commented 2 weeks ago

It seems not possible to reproduce, start.vaadin.com generates a Java MainLayout project. Steps for Hilla:

start.vaadin.com → new project → add Hilla view (adds as index) → download → delete Hilla @index.tsx view

Artur- commented 1 week ago

Fixed in https://github.com/vaadin/hilla/pull/2572, released in 24.4.4