vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
864 stars 58 forks source link

test: fix CI failures #2566

Closed Lodin closed 1 week ago

Lodin commented 1 week ago

In @vaadin/hilla-react-crud there was some weird test failures. Assumable, the culprit is the animation timing. It is asynchronous and isn't included in await user.click(). The nextFrame call after the click could fix the issue

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.00%. Comparing base (01d2d55) to head (3a2200b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2566 +/- ## ========================================== + Coverage 94.98% 95.00% +0.02% ========================================== Files 66 66 Lines 4546 4546 Branches 660 661 +1 ========================================== + Hits 4318 4319 +1 + Misses 183 182 -1 Partials 45 45 ``` | [Flag](https://app.codecov.io/gh/vaadin/hilla/pull/2566/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/hilla/pull/2566/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `95.00% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 1 week ago

Hi @Lodin and @platosha, when i performed cherry-pick to this commit to 2.5, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 17ed1d88972ccc8e46676cdb3ffb5cd15cee9ed3 error: could not apply 17ed1d88... test: fix CI failures (#2566) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".