vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
864 stars 58 forks source link

refactor: Do not use installAutoSignalTracking #2576

Closed Artur- closed 3 days ago

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.81%. Comparing base (210fae2) to head (78176cf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2576 +/- ## ========================================== + Coverage 90.71% 90.81% +0.10% ========================================== Files 66 66 Lines 2649 2765 +116 Branches 528 528 ========================================== + Hits 2403 2511 +108 - Misses 77 79 +2 - Partials 169 175 +6 ``` | [Flag](https://app.codecov.io/gh/vaadin/hilla/pull/2576/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/hilla/pull/2576/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `90.81% <ø> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Artur- commented 1 week ago

Depends on https://github.com/vaadin/flow/pull/19639

Artur- commented 1 week ago

With the Flow PR, at least react-i18n and react-signals pass locally

Artur- commented 1 week ago

Maybe there is a better way with Karma to add

window.$RefreshReg$ = () => {}
window.$RefreshSig$ = () => (type) => type
window.__vite_plugin_react_preamble_installed__ = true

The "correct" way would be to pass the HTML files through Vite but I don't see how that would be possible

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud