search

vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
921 stars 58 forks source link

hillaI18n Feature flags for experimental features is ignored in production mode #2750

Closed jcgueriaud1 closed 6 days ago

jcgueriaud1 commented 1 month ago

Describe the bug

This issue is still happening in Vaadin 24.4.12 and Vaadin 24.5.0.beta1.

https://github.com/vaadin/hilla/issues/2637

I have a file vaadin-featureflags.properties which contains com.vaadin.experimental.hillaI18n=true. In my local environment, the i18n-instance can be used without problems. However, in my production build, the frontend crashes with the error The Hilla I18n API is currently considered experimental and may change in the future. To use it you need to explicitly enable it in Copilot or by adding com.vaadin.experimental.hillaI18n=true to vaadin-featureflags.properties.

Expected-behavior

No response

Reproduction

https://github.com/jcgueriaud1/spring-petclinic-vaadin-flow/tree/hilla

Build and run the application in production mode

System Info

Vaadin 24.4.12 and Vaadin 24.5.0.beta1

platosha commented 1 month ago

Last time this was caused by using a wrong class loader when generating feature flags TypeScript values in production build.

cromoteca commented 2 weeks ago

Fixed in 24.6 by https://github.com/vaadin/platform/pull/6897, cherry-picked to 24.5 and 24.4. It will be included in the next patch releases.

jcgueriaud1 commented 1 week ago

Fixed in 24.5.1

sveinnetnordic commented 1 week ago

Works for me :-)

cromoteca commented 6 days ago

Released in 24.5.1 and 24.4.16.