vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
923 stars 57 forks source link

fix(crud): use 3-params overload for dates instead of separate assignments #2894

Closed cromoteca closed 2 weeks ago

cromoteca commented 2 weeks ago

Assigning year, month, and day, in this order, is problematic when the chosen month has less days than the current day of month.

So, for example, on Oct. 31st 2024, choosing Sept. 15th 2024 leads to 2024 -> Sept. 31 -> Oct. 1 -> Oct. 15.

Passing the 3 parameters at once avoids this problem.

Fixes #2887

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.67%. Comparing base (83a01b4) to head (d5c9287). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2894 +/- ## ========================================== - Coverage 92.68% 92.67% -0.02% ========================================== Files 83 83 Lines 2830 2826 -4 Branches 728 728 ========================================== - Hits 2623 2619 -4 Misses 156 156 Partials 51 51 ``` | [Flag](https://app.codecov.io/gh/vaadin/hilla/pull/2894/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/hilla/pull/2894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `92.67% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.