vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
923 stars 57 forks source link

fix: allow dynamically import atmosphere.js for SW context #2901

Open krissvaa opened 1 week ago

krissvaa commented 1 week ago

Fixes #2867

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (cf3a028) to head (3ba43b0).

Files with missing lines Patch % Lines
packages/ts/frontend/src/FluxConnection.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## fix/sw-context-access #2901 +/- ## ========================================================= - Coverage 92.54% 92.52% -0.03% ========================================================= Files 83 83 Lines 2832 2836 +4 Branches 732 733 +1 ========================================================= + Hits 2621 2624 +3 - Misses 156 157 +1 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/vaadin/hilla/pull/2901/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/hilla/pull/2901/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `92.52% <80.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.