vaadin / intellij-plugin

Vaadin IntelliJ Plugin
Apache License 2.0
5 stars 1 forks source link

Improve Vaadin project detection #33

Closed MarcinVaadin closed 1 month ago

MarcinVaadin commented 7 months ago

Currently there is simple String::contains search of com.vaadin inside pom.xml / build.gradle to detect Vaadin project. It might cause lot of false positives. For parsing pom.xml maven-model might be used. For gradle file there is gradle-tooling-api but it's bit more complex to use.

Also there is no multi module detection of Vaadin child projects.

MarcinVaadin commented 3 months ago

Update:

On multimodule projects, root module might not contain Vaadin dependency - Vaadin plugin is not started.

Artur- commented 2 months ago

Note that as part of the "Debug as hotswap", parsing of some build data for both Maven and Gradle were added so you can do e.g.

var deps: List<MavenArtifact> = MavenProjectsManager.getInstance(module.project).findProject(module)!!.dependencies

and also find a parent project

var parentId: MavenId = MavenProjectsManager.getInstance(module.project).findProject(module)!!.parentId!!;
MavenProjectsManager.getInstance(module.project).findProject(parentId)
Artur- commented 1 month ago

Was this fixed by #82 ?

MarcinVaadin commented 1 month ago

Yes