search

vaadin / kubernetes-kit

Other
2 stars 2 forks source link

Add serialization and deserialization success and error callbacks #113

Closed tamasmak closed 6 months ago

tamasmak commented 6 months ago

Adds SessionSerializationCallback::onSerializationSuccess, SessionSerializationCallback::onSerializationError, SessionSerializationCallback::onDeserializationSuccess, SessionSerializationCallback::onDeserializationError callbacks which are called after a successful serialization and deserialization, or when error happens during the serialization and deserialization.

Closes #108

mcollovati commented 6 months ago

Good job @tamasmak, and thank you for the patience tackling all the comments :grin:

MichaelPluessErni commented 5 months ago

@mcollovati Thank you very much for this cool feature! I noticed a problem when trying out the SessionSerializationCallback with the Kubernetes Kit Debugger: I cannot test both things together, because the DEFAULT SessionSerializationCallback is always used in SerializationDebugRequestHandler::serializeAndDeserialize. It would be cool, if I was able to inject my own callback bean when testing together with the Kubernetes Kit Debug Tool.

mcollovati commented 5 months ago

@MichaelPluessErni thanks for feedback. I think this is doable. Do you mind creating a new ticket for this enhancement? BTW, I wonder if it would make sense for the callback injected into SerializationDebugRequestHandler to have a specific qualifier so that it might be different from the callback used in production.