fix: run debug tool after Vaadin request is processed

mcollovati commented 1 year ago

Description

Debug Tool is now executed by an HTTP Filter at the end of the request. The Filter gets an executable command set by the RequestHandler as request attribute, only for UIDL requests. If PUSH is enabled, a notification will visible on the browser in case of failures.

Fixes #44 Fixes #46

Type of change

[ ] Bugfix
[ ] Feature

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[x] I have added tests to ensure my change is effective and works as intended.
[x] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

jouni commented 1 year ago

Should we treat this as an official named tool? I see it's currently being referred to in both lower and uppercase in the docs ("debug tool" and "Debug Tool").

mcollovati commented 1 year ago

Should we treat this as an official named tool? I see it's currently being referred to in both lower and uppercase in the docs ("debug tool" and "Debug Tool").

We will use the lowercase form. I'll update the docs

mcollovati commented 1 year ago

There is no such word as "notificator". Can we rename the component to SessionDebugNotifier?

@MatthewVaadin we have also VersionNotificator for the cluster support. We should change that also, but perhaps in another PR

vaadin / kubernetes-kit