search

vaadin / kubernetes-kit

Other
2 stars 2 forks source link

Kubernetes Kit - Session Replication Debug Tool - Configurable Timeout #94

Closed MichaelPluessErni closed 8 months ago

MichaelPluessErni commented 10 months ago

Describe your motivation

When using the Session Replication Debug Tool from the Kubernetes Kit, we constantly ran into the issue of triggering the timeout, when serializing the Vaadin Session.

The timeout is fixed at 10 seconds and our work laptops often needed 8 to 12 seconds for serializing a session. Thus we constantly ran into false positives when looking for serialization bugs.

Describe the solution you'd like

We would have appreciated if there was a possibility to configure the timeout of the Session Replication Debug Tool.

Describe alternatives you've considered

We considered extending and changing functionality from the Debug Tool but this was too complicated with too little promise of success.

Additional context

No response

heruan commented 9 months ago

Thanks for the suggestion! The timeout is indeed hardcoded in https://github.com/vaadin/kubernetes-kit/blob/4e345d442c1ef0ff51389a23b414c4763ab3e60e/kubernetes-kit-starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/serialization/debug/DebugBackendConnector.java#L74 and we will look into making this configurable.

jorgheymans commented 9 months ago

+1 for a configurable time-out, large sessions easily take more than 10 seconds on the local laptop.