search

vaadin / maven-plugin

Vaadin Maven Plug-in
4 stars 18 forks source link

Download the widget set again if somebody has deleted the target/classes folder #84

Closed Artur- closed 7 years ago

Artur- commented 7 years ago

Fixes #81

This change is Reviewable

denis-anisimov commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/main/java/org/codehaus/mojo/gwt/shell/CompileMojo.java, line 710 at r1 (raw file):

                    && FileUtils.readFileToString(lastWidgetset)
                            .equals(wsReq.toWidgetsetString())
                    && directoryHasContent(getOutputDirectory())) {

This just checks the directory presence and it's not emptiness. What if directory hasn't been removed but there is no widgetset ?

Since this change tries to fix some failsafe way then this should also be considered....

Comments from Reviewable

Artur- commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/main/java/org/codehaus/mojo/gwt/shell/CompileMojo.java, line 710 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…
This just checks the directory presence and it's not emptiness. What if directory hasn't been removed but there is no widgetset ? Since this change tries to fix some failsafe way then this should also be considered....

Improved to check for the .nocache.js file

Comments from Reviewable

denis-anisimov commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable