search

vaadin / maven-plugin

Vaadin Maven Plug-in
4 stars 18 forks source link

Download the widget set again if somebody has deleted target/classes #86

Closed Artur- closed 3 years ago

Artur- commented 7 years ago

Picked from master

Fixes #81

This change is Reviewable

denis-anisimov commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

pleku commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

src/main/java/org/codehaus/mojo/gwt/shell/CompileMojo.java, line 750 at r1 (raw file):

        for (File contents : directory.listFiles()) {
            if (contents.isDirectory()) {
                String wsName = contents.getName() + ".nocache.js";

wsName should be declared final

Compilation failure
[ERROR] /home/travis/build/vaadin/maven-plugin/src/main/java/org/codehaus/mojo/gwt/shell/CompileMojo.java:[754,44] local variable wsName is accessed from within inner class; needs to be declared final

Comments from Reviewable