chore: added observable application

vaadin / observability-kit

Other

5 stars 2 forks source link

chore: added observable application #158

Closed mcollovati closed 1 year ago

mcollovati commented 1 year ago

Description

Added a Vaadin + Spring Boot application with bugs and performance issues that can be discovered using the Kit

Part of #152

Type of change

[ ] Bugfix
[ ] Feature

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[ ] New and existing tests are passing locally with my change.
[ ] I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

mcollovati commented 1 year ago

The demo application has a dependency to the Vaadin platform BOM. @ZheSun88 is this a practice that should be avoided? Shall we exclude the module from the root pom?

heruan commented 1 year ago

The demo application has a dependency to the Vaadin platform BOM. @ZheSun88 is this a practice that should be avoided? Shall we exclude the module from the root pom?

Yes, we should avoid using the platform BOM otherwise we create circular dependencies during the release process. Let's add only the needed component dependencies using the Flow version instead.

mcollovati commented 1 year ago

@heruan do we need to add license header for the demo app sources? If so, what license should be applied, Apache 2 or the Vaadin Commercial License?

mcollovati commented 1 year ago

I'm wondering if we might refactor the demo as a Kubernetes cluster including all the needed containers, similar to what has been drafted in vaadin/kubernetes-kit#16

It seems a good idea. I think it may be worth to also including a docker-compose configuration, as an easier setup.

mcollovati commented 1 year ago

I'm wondering if we might refactor the demo as a Kubernetes cluster including all the needed containers, similar to what has been drafted in https://github.com/vaadin/kubernetes-kit/pull/16

If we want the demo to be packed as a container, It may be better to replace the generated data with a SQL script. Otherwise the docker container should have node installed

vaadin / observability-kit