search

vaadin / observability-kit

Other
5 stars 3 forks source link

test using hub #159

Closed ZheSun88 closed 1 year ago

ZheSun88 commented 1 year ago

ah. good point.. let me try..

mcollovati commented 1 year ago

My bad here. The Flow test utility module is based on Testbench API for JUnit4. For JUnit 5 we need to depend on vaadin-testbench-core-junit5, make the abstract class extend BrowserTestBase and annotate test methods with @BrowserTest instead of @Test

heruan commented 1 year ago

For JUnit 5 we need to depend on vaadin-testbench-core-junit5, make the abstract class extend BrowserTestBase and annotate test methods with @BrowserTest instead of @Test

I made those changes, let's see if it validates now. Locally I'm getting this error:

[ERROR] Errors:
[ERROR]   MainViewIT.setUp:30->AbstractViewIT.setUp:36 » WebDriver unknown error: net::E...
[ERROR]   MainViewIT.setUp:30->AbstractViewIT.setUp:36 » WebDriver unknown error: net::E...
[INFO]
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0
mcollovati commented 1 year ago

With the latest commit test are passing locally for me

mcollovati commented 1 year ago

The only thing I don't like that much is that locally, the test is not executed headless