search

vaadin / observability-kit

Other
5 stars 3 forks source link

Rename Hilla package and update deps #244

Closed heruan closed 7 months ago

heruan commented 7 months ago

This follows #243 with the missing changes and closes #242

heruan commented 7 months ago

Converting to draft to wait for the @vaadin/hilla-core ➡️ @vaadin/hilla-frontend rename.

heruan commented 7 months ago

Demos still don't run, fixing them after next alpha.

manolo commented 7 months ago

When I run:

git clone git@github.com:vaadin/observability-kit.git
cd observability-kit/
git checkout chore/rename-hilla-package
mvn clean install -DskipTests -U
cd observability-kit-demo-hilla
mvn -Dspring-boot.run.arguments="--com.example.application.hilla.auth.secret=here_my_app_secret_key"

I get the following error in a loop:

Caused by: com.vaadin.flow.server.ExecutionFailedException: Npm install has exited with non zero status. Some dependencies are not installed. Check npm command output
    at com.vaadin.flow.server.frontend.TaskRunNpmInstall.runNpmInstall(TaskRunNpmInstall.java:334) ~[flow-server-24.4-SNAPSHOT.jar:24.4-SNAPSHOT]

Then I run 

npm i

And the error is

npm ERR! code 1
npm ERR! path /private/tmp/o11y/observability-kit/ts/observability-kit-client
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > @vaadin/observability-kit-client@3.0.0 build
npm ERR! > concurrently npm:build:code npm:build:dts
npm ERR! sh: concurrently: command not found
npm ERR! npm ERR! Lifecycle script `build` failed with error:
npm ERR! npm ERR! Error: command failed
npm ERR! npm ERR!   in workspace: @vaadin/observability-kit-client@3.0.0
npm ERR! npm ERR!   at location: /private/tmp/o11y/observability-kit/ts/observability-kit-client

The culprit is

./ts/observability-kit-client/package.json:    "build": "concurrently npm:build:code npm:build:dts",

but If I try

npm i concurrently --save

it fails because observability-kit-client needs to be installed first

npm ERR! code 1
npm ERR! path /private/tmp/o11y/observability-kit/ts/observability-kit-client
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > @vaadin/observability-kit-client@3.0.0 build
npm ERR! > concurrently npm:build:code npm:build:dts
npm ERR! sh: concurrently: command not found
npm ERR! npm ERR! Lifecycle script `build` failed with error:
npm ERR! npm ERR! Error: command failed
npm ERR! npm ERR!   in workspace: @vaadin/observability-kit-client@3.0.0
npm ERR! npm ERR!   at location: /private/tmp/o11y/observability-kit/ts/observability-kit-client
heruan commented 7 months ago

The concurrently dependency is defined in the root package.json:

https://github.com/vaadin/observability-kit/blob/a209536c00f0f9d2ad61ac57bc71a4b385437f8a/package.json#L32

It is installed with npm install from the project root, and then it's found by the submodules looking in ../node_modules (by default).