search

vaadin / observability-kit

Other
5 stars 3 forks source link

chore: add basic formatting and linting #45

Closed sissbruecker closed 2 years ago

sissbruecker commented 2 years ago

Description

Add basic linting and formatting. Used the Google AOSP code format as that seemed closest to what we had, but we can also pick something else.

caalador commented 2 years ago

I had the same idea and setup, but I would go with the formatter used in Flow and others that is defined in VaadinConventions that would have the gradle setup:

spotless {
  java {
    eclipse().configFile('eclipse/VaadinJavaConventions.xml')
    importOrder('\\#', 'elemental', 'com.vaadin', 'com.google.gwt', '', 'java', 'javax')
  }
}
sissbruecker commented 2 years ago

I had the same idea and setup, but I would go with the formatter used in Flow and others that is defined in VaadinConventions that would have the gradle setup:

spotless {
  java {
    eclipse().configFile('eclipse/VaadinJavaConventions.xml')
    importOrder('\\#', 'elemental', 'com.vaadin', 'com.google.gwt', '', 'java', 'javax')
  }
}

Done