search

vaadin / observability-kit

Other
5 stars 2 forks source link

Add instrumentation for SessionRequestHandler #60

Closed MatthewVaadin closed 2 years ago

MatthewVaadin commented 2 years ago

Description

Add instrumentation for SessionRequestHandler.

MatthewVaadin commented 2 years ago

I'm not sure what we can add to the span from the VaadinSession, VaadinRequest or VaadinResponse.

caalador commented 2 years ago

Not that I'm looking at this and what it does I would almost make this a trace level handler so that if you want all the info it would be used, but else it would just not show up as a span. As now it would only collect under it the run handlers which might not be that important to know.

caalador commented 2 years ago

You need to execute gradle spotlessApply to format the code. I build my test package with gradle clean spotlessApply build extendedAgent so that the formatting is not forgotten.