search

vaadin / patient-portal-demo-flow

0 stars 0 forks source link

Sonar and Testbench #37

Closed gilberto-torrezan closed 7 years ago

gilberto-torrezan commented 7 years ago

Fix #31

This change is Reviewable

gilberto-torrezan commented 7 years ago

We are having problems with the SonarQube server at the moment: the host certificate expired, and APIs calls to the host fail due to connection security errors. So this patch is pointless until the certificate problem is fixed.

SomeoneToIgnore commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

.travis.script.sh, line 8 at r1 (raw file):

# TRAVIS_REPO_SLUG == the repository, e.g. vaadin/vaadin

# Exclude the bower_components and node_modules from Sonar analysis

Guess you need to update the file once again.

Comments from Reviewable

SomeoneToIgnore commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

gilberto-torrezan commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

.travis.script.sh, line 8 at r1 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Guess you need to update the file once again.

Here we go with the SKIP_SONAR once again. I hope I didn't hit a bash syntax gotcha this time.

Comments from Reviewable