Wait for the view before assertions

vaadin / patient-portal-demo-flow

0 stars 0 forks source link

Wait for the view before assertions #50

Closed denis-anisimov closed 7 years ago

denis-anisimov commented 7 years ago

Tests on Travis doesn't show patients table immediately after the login page. So one needs to wait for patients view before any check against the table.
Timeout for location checks is increased.

This change is

SomeoneToIgnore commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

SomeoneToIgnore commented 7 years ago

Why is there such a difference between master and local IT tests? Do we use production mode for only of of those?

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

denis-anisimov commented 7 years ago

What do you mean "master"/"local" ? There is no difference in the tests. There is a difference in their execution on Travis and locally. This difference has been always a pain.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

SomeoneToIgnore commented 7 years ago

I mean that Travis pull requests' IT tests are passing almost always: https://travis-ci.com/vaadin/patient-portal-demo-flow/pull_requests

but the same Travis builds for master branch fail always: https://travis-ci.com/vaadin/patient-portal-demo-flow/branches

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

denis-anisimov commented 7 years ago

Aaaah, yeah. Good question. I have no idea.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

SomeoneToIgnore commented 7 years ago

I'll create a ticket then.

Comments from Reviewable