search

vaadin / patient-portal-demo-flow

0 stars 0 forks source link

Fix patient-specific navigation #56

Closed pekam closed 7 years ago

pekam commented 7 years ago

Now clicking the patients-grid navigates to the clicked patient, and navigating inside patient-details keeps the current patient.

Resolves #33 Resolves #30

This change is Reviewable

vaadin-bot commented 7 years ago

SonarQube analysis reported 1 issue

Watch the comments in this conversation to review them.

denis-anisimov commented 7 years ago

Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

a discussion (no related file): Tests ?

Comments from Reviewable

pekam commented 7 years ago

Review status: 5 of 6 files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):

Previously, denis-anisimov (Denis) wrote…
Tests ?

done

Comments from Reviewable

denis-anisimov commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

a discussion (no related file):

Previously, pekam (Pekka Maanpää) wrote…
done

So there are no new tests. It's the same test with just a new patient id. What does the new id change ?

Comments from Reviewable

pekam commented 7 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

a discussion (no related file):

Previously, denis-anisimov (Denis) wrote…
So there are no new tests. It's the same test with just a new patient id. What does the new id change ?

Previously all patient-specific navigation used patient id 1. So the test wouldn't have worked with any other patient id. With this PR it's fixed so that clicking on any patient in the grid navigates to the correct patient instead always the first patient. And same with clicking links in patient-profile to patient's journal etc.

Comments from Reviewable