search

vaadin / platform

Vaadin platform 10+ is a Java web development platform based on Vaadin web components. If you don't know to which repository your bug report should be filed, use this and we'll move it to the right one.
https://vaadin.com
515 stars 76 forks source link

Drop bower for 15.x from vaadin-core and vaadin #1056

Closed web-padawan closed 4 years ago

web-padawan commented 4 years ago

Currently vaadin-core package contains vaadin-router which is not published to bower. This causes the CI builds on master branch to fail with the following error:

bower ENOTFOUND     Package vaadin-router not found
The command "bower install" failed and exited with 1 during .

There was already an issue #904 but apparently it did not cover this. There should be no more bower.json for V15.

ZheSun88 commented 4 years ago

probably just remove this line is enough https://github.com/vaadin/vaadin-core/blob/master/.travis.yml#L17? how do you think?

web-padawan commented 4 years ago

Agreed. It should be removed from master for sure.

web-padawan commented 4 years ago

Another thing that needs to be removed is bower.json itself (and the script that updates it).

web-padawan commented 4 years ago

Submitted https://github.com/vaadin/vaadin-core/pull/231

ZheSun88 commented 4 years ago

merged.

web-padawan commented 4 years ago

@ZheSun88 please also this one https://github.com/vaadin/vaadin/pull/60