vaadin / platform

Vaadin platform 10+ is a Java web development platform based on Vaadin web components. If you don't know to which repository your bug report should be filed, use this and we'll move it to the right one.
https://vaadin.com
515 stars 76 forks source link

Add spring-boot-starter to bom #210

Closed Artur- closed 5 years ago

Artur- commented 5 years ago

This change is Reviewable

SomeoneToIgnore commented 5 years ago

Review status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Artur-)


versions.json, line 9 at r1 (raw file):

            "javaVersion": "10.0.0.rc2"
        },
        "vaadin-spring-boot-starter": {

Please also edit the template file: https://github.com/vaadin/platform/blob/master/scripts/generator/templates/template-vaadin-bom.xml

If you find this confusing, please also edit README.md or any other file and add the instructions on how to change the bom.


Comments from Reviewable

SomeoneToIgnore commented 5 years ago

versions.json, line 11 at r1 (raw file):

····

We don't really need trailing whitespaces here, do we?


Comments from Reviewable

SomeoneToIgnore commented 5 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed, 2 unresolved discussions (waiting on @Artur-)


Comments from Reviewable

SomeoneToIgnore commented 5 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed, 1 unresolved discussion (waiting on @Artur-)


Comments from Reviewable

SomeoneToIgnore commented 5 years ago
:lgtm:

Review status: 1 of 2 files reviewed, all discussions resolved (waiting on @SomeoneToIgnore)


Comments from Reviewable

SomeoneToIgnore commented 5 years ago

Reviewed 1 of 1 files at r3. Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

Artur- commented 5 years ago

Review status: :shipit: complete! all files reviewed, all discussions resolved


versions.json, line 9 at r1 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Please also edit the template file: https://github.com/vaadin/platform/blob/master/scripts/generator/templates/template-vaadin-bom.xml If you find this confusing, please also edit `README.md` or any other file and add the instructions on how to change the bom.

Done.


versions.json, line 11 at r1 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
> ``` > ···· > ``` We don't really need trailing whitespaces here, do we?

Done


Comments from Reviewable