search

vaadin / platform

Vaadin platform 10+ is a Java web development platform based on Vaadin web components. If you don't know to which repository your bug report should be filed, use this and we'll move it to the right one.
https://vaadin.com
552 stars 78 forks source link

Missing `vaadin-versions.json` for dev.hilla:hilla #3089

Closed platosha closed 2 years ago

platosha commented 2 years ago

Describe the bug

After the platform pinned versions split, Flow frontend tasks take vaadin-versions.json or vaadin-core-versions.json resources into use. The dev.hilla:hilla artifact was not updated accordingly yet.

As a result, webpack fails to compile TypeScript views in a Hilla project because web components cannot be resolved.

Expected-behavior

dev.hilla:hilla 1.2-SNAPSHOT has vaadin-versions.json resource.

Upon starting the development server with a Hilla project without prior node_modules installed, Vaadin components are automatically installed from npm.

Reproduction

  1. Start a new Hilla project using 1.2-SNAPSHOT version of the Hilla platform dependency. Alternatively, remove node_modules in an existing up-to-date project.
  2. Start the development server normally to run frontend package.json update and npm install tasks.

System Info

Hilla 1.2-SNAPSHOT

vaadin-bot commented 2 years ago

Thanks for using Vaadin! We appreciate your help and we’ll take care of this as soon as possible.

ZheSun88 commented 2 years ago

oh,i see.. this place needs to be modified after the recent split.. https://github.com/vaadin/platform/blob/master/hilla/pom.xml#L131

and one thing to mention here, do we need to separate the versions.json here too?

platosha commented 2 years ago

We don’t even have hilla-core yet. Looks like separation is out of scope for this bugfix.