search

vaadin / platform

Vaadin platform 10+ is a Java web development platform based on Vaadin web components. If you don't know to which repository your bug report should be filed, use this and we'll move it to the right one.
https://vaadin.com
545 stars 78 forks source link

Vaadin Maven Plugin not thread-safe #6688

Open knoobie opened 3 weeks ago

knoobie commented 3 weeks ago

Describe the bug

    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * Your build is requesting parallel execution, but this         *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * project contains the following plugin(s) that have goals not  *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * marked as thread-safe to support parallel execution.          *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * While this /may/ work fine, please look for plugin updates    *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * and/or request plugins be made thread-safe.                   *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * If reporting an issue, report it against the plugin in        *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * question, not against Apache Maven.                           *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - The following plugins are not marked as thread-safe in Project Name:
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -   com.vaadin:vaadin-maven-plugin:24.4.10
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - Enable debug to see precisely which goals are not marked as thread-safe.
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************

Expected-behavior

No such error.

Reproduction

Build any Vaadin Multi Module Project with Maven and enable parallel execution to speed up build.

System Info

Latest 24.4

manolo commented 3 weeks ago

I have seen this message before when building platform o flow-components that are using parallel execution, but we have not experienced any problem, so we just ignore the message, has you had any issue in your projects?

knoobie commented 3 weeks ago

Not seen a problem in the final product; but maven is literally crying ;) and all WARNING logs are preserved in Jenkins.. so it's not a good DX / advertising for the plugin

manolo commented 3 weeks ago

which goal do you expect to be thread-safe ? prepare-frontend or build-frontend ?

knoobie commented 3 weeks ago

I would expect build-frontend used in the production build to be thread-safe.. I would say even running a multi module project with different Vaadin modules should not be a problem because each has its own node modules, package json etc.