search

vaadin / portlet

Portlet support for Vaadin Flow
https://vaadin.com
Other
2 stars 3 forks source link

Address issues raised by sonar #120

Closed ujoni closed 5 years ago

ujoni commented 5 years ago

Some issues raised by sonar that did not fit the open PR

This change is Reviewable

vaadin-bot commented 5 years ago

SonarQube analysis reported 4 issues

Watch the comments in this conversation to review them.

3 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VaadinPortlet.java#L373: Remove usage of generic wildcard type. rule
  2. MINOR VaadinPortlet.java#L310: Remove this use of "getParameterMap"; it is deprecated. rule
  3. INFO VaadinPortletService.java#L225: Complete the task associated to this TODO comment. rule