search

vaadin / portlet

Portlet support for Vaadin Flow
https://vaadin.com
Other
2 stars 3 forks source link

Use factory instead of ExportsWebComponent interface #151

Closed denis-anisimov closed 4 years ago

denis-anisimov commented 4 years ago

Update the code according to the latest Flow changes: use a factory instead of implementing the interface

Fixes #74

This change is Reviewable

vaadin-bot commented 4 years ago

SonarQube analysis reported 5 issues

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VaadinPortlet.java#L447: Remove usage of generic wildcard type. rule
  2. MAJOR PortletBootstrapHandler.java#L103: Either log or rethrow this exception. rule
  3. MINOR VaadinPortlet.java#L381: Remove this use of "getParameterMap"; it is deprecated. rule
  4. MINOR VaadinPortlet.java#L568: Move this method into "PortletWebComponentExporter". rule