search

vaadin / portlet

Portlet support for Vaadin Flow
https://vaadin.com
Other
2 stars 3 forks source link

Fail server-side if trying to fire a hub event in Portlet 2.0 or older #175

Closed joheriks closed 4 years ago

joheriks commented 4 years ago

Fixes #174

This change is Reviewable

caalador commented 4 years ago

This PR has been stale for quite a while. Could it be closed and a new one made when work continues?

vaadin-bot commented 4 years ago

SonarQube analysis reported 9 issues

Watch the comments in this conversation to review them.

7 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR AbstractPlutoPortalTest.java#L207: Call "Optional#isPresent()" before accessing the value. rule
  2. MINOR AbstractPlutoPortalTest.java#L83: Move this variable to comply with Java Code Conventions. rule
  3. MINOR PortletViewContext.java#L357: This call to "add()" may be a performance hot spot if the collection is large. rule
  4. MINOR PortletViewContext.java#L358: This call to "remove()" may be a performance hot spot if the collection is large. rule
  5. MINOR PortletViewContext.java#L363: This call to "add()" may be a performance hot spot if the collection is large. rule
  6. MINOR PortletViewContext.java#L364: This call to "remove()" may be a performance hot spot if the collection is large. rule
  7. MINOR VaadinPortlet.java#L356: Remove this use of "getParameterMap"; it is deprecated. rule