search

vaadin / quarkus

An extension to Quarkus to support Vaadin Flow
Apache License 2.0
28 stars 3 forks source link

vaadin from code.quarkus.io dont have right vaadin version #133

Closed maxandersen closed 1 year ago

maxandersen commented 1 year ago

not sure if this is right repo to report this but I tried vaadin from code.quarkus and got a project but when building it it fails:

[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.acme:code-with-quarkus:1.0.0-SNAPSHOT (/Users/manderse/code/quarkusio/quarkus-workshops/code-with-quarkus/pom.xml) has 6 errors
[ERROR]     Resolving expression: '${vaadin.version}': Detected the following recursive expression cycle in 'vaadin.version': [vaadin.version] -> [Help 2]
[ERROR]     Resolving expression: '${vaadin.version}': Detected the following recursive expression cycle in 'vaadin.version': [vaadin.version] -> [Help 2]
[ERROR]     Resolving expression: '${vaadin.version}': Detected the following recursive expression cycle in 'vaadin.version': [vaadin.version] -> [Help 2]
[ERROR]     Resolving expression: '${vaadin.version}': Detected the following recursive expression cycle in 'vaadin.version': [vaadin.version] -> [Help 2]
[ERROR]     'dependencyManagement.dependencies.dependency.version' for com.vaadin:vaadin-bom:pom is missing. @ line 29, column 19
[ERROR]     'dependencies.dependency.version' for com.vaadin:vaadin-quarkus-extension:jar is missing. @ line 56, column 16
[ERROR]
maxandersen commented 1 year ago

replacing <vaadin.version>${vaadin.version}</vaadin.version> with <vaadin.version>24.1.0</vaadin.version> makes the project work.

I guess there is a missing placeholder replacement somewhere?

mcollovati commented 1 year ago

Hi, thank you for reporting. This is a known issue because the Vaadin Quarkus add-on does not know the exact version of the Vaadin platform it will be shipped with.

Currently, the version should be provided as a parameter

mvn io.quarkus.platform:quarkus-maven-plugin:3.0.1.Final:create \
 -DprojectGroupId=org.acme -DprojectArtifactId=getting-started \
 -Dextensions='com.vaadin:vaadin-quarkus' -DwithCodestart \
 -Ddata="vaadin-flow-codestart.vaadinVersion=24.1.0"

The -Ddata="vaadin-flow-codestart.vaadinVersion=24.1.0" parameter does the trick

This will be fixed in one of the next platform releases, after the coordinates of the extension on the Quarkus catalog will change to com.vaadin:vaadin-quarkus-extension.

mshabarov commented 1 year ago

Waits for next Vaadin platform release and update of https://github.com/quarkusio/quarkus-extension-catalog/blob/main/extensions/vaadin.yaml .

mcollovati commented 1 year ago

The quarkus extension catalog has been updated and now on code.start.io you can find the vaadin-quarkus-extension extension, that provides a codestart that correctly fills the vaadin.version property