vaadin / quarkus

An extension to Quarkus to support Vaadin Flow
Apache License 2.0
28 stars 3 forks source link

test: retry count assertion on session invalidation #134

Closed mcollovati closed 1 year ago

mcollovati commented 1 year ago

Description

Session context tests check the counter value hold by a session bean right after invalidating the Vaadin session. Since the counter is incremented in the PreDestroy hook, it may happen that when the test checks for the counter value, the callback has not yet been invoked. This change retries the counter check for at most on second, to prevent test flakyness.

Fixes #126

Type of change

Checklist

Additional for Feature type of change

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mcollovati commented 1 year ago

Closing because the force-push has not been detected by the PR. I'll try to see if reopen updates the PR; otherwise I'll create a new one