Closed caalador closed 2 months ago
Depends on vaadin/flow#19136 Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.
Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.
Is it reasonable to have two separated commits for version bump and the instantiator change and then do a rebase and merge
instead of squash?
A minor nit: swapping the order of the commits would make both of them compilable once we have the new Flow snapshot. With the current order (first code changes than Flow bump) the first commit will be broken.
It would be nice to add I18n test (normal usage + background thread), but we can do it in another PR. Probably there are also other features missing some test
Now the test is there and the assertions should be build in the correct order.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Use a classLoader that is compatible with quarkus for default i18N translation.
part of vaadin/flow#18977