vaadin / quarkus

An extension to Quarkus to support Vaadin Flow
Apache License 2.0
28 stars 3 forks source link

fix: use quarkus compatible classloader #149

Closed caalador closed 2 months ago

caalador commented 2 months ago

Use a classLoader that is compatible with quarkus for default i18N translation.

part of vaadin/flow#18977

caalador commented 2 months ago

Depends on vaadin/flow#19136 Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.

mcollovati commented 2 months ago

Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.

Is it reasonable to have two separated commits for version bump and the instantiator change and then do a rebase and merge instead of squash?

mcollovati commented 2 months ago

A minor nit: swapping the order of the commits would make both of them compilable once we have the new Flow snapshot. With the current order (first code changes than Flow bump) the first commit will be broken.

mcollovati commented 2 months ago

It would be nice to add I18n test (normal usage + background thread), but we can do it in another PR. Probably there are also other features missing some test

caalador commented 2 months ago

Now the test is there and the assertions should be build in the correct order.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud