feat: fire session init/destroy and ui init events via bean manager - Githubissues

vaadin / quarkus

An extension to Quarkus to support Vaadin Flow

Apache License 2.0

28 stars 3 forks source link

feat: fire session init/destroy and ui init events via bean manager #29

Closed denis-anisimov closed 2 years ago

denis-anisimov commented 2 years ago

Feature allows to listen mentioned events using @Observes methods.

fixes #21

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

[ ] Bugfix
[x] Feature

Checklist

[ ] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[ ] I have added a description following the guideline.
[ ] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[ ] New and existing tests are passing locally with my change.
[ ] I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

denis-anisimov commented 2 years ago

ServiceTest.serviceScopedBeanIsPreservedAcrossUIs seems to fail after these changes
org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
  at com.vaadin.flow.quarkus.it.ServiceTest.serviceScopedBeanIsPreservedAcrossUIs(ServiceTest.java:64)

It looks like the tests somehow influence each other: if I disable newly added tests then everything works fine. And locally everything is OK. I've extracted the new tests into separate class. Let's see whether it helps.