vaadin / quarkus

An extension to Quarkus to support Vaadin Flow
Apache License 2.0
28 stars 3 forks source link

Skip user `VaadinServlet`s without @WebServlet instead of NPE on `quarkusBuild` #77

Closed grossws closed 2 years ago

grossws commented 2 years ago

Description

If VaadinServlet without @WebServlet annotation present (like when vaadin-cdi happened to be in classpath) currently quarkusBuild will fail with NPE.

This patch skips such servlets with a warning in log.

Fixes #76

Type of change

Checklist

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

mcollovati commented 2 years ago

@grossws thanks for the contribution! Do you mind signing the CLA?

grossws commented 2 years ago

@mcollovati, I've signed CLA, feel free to merge.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information