search

vaadin / react-components

15 stars 4 forks source link

fix: add GridTreeColumn header and footer renderers #194

Closed web-padawan closed 11 months ago

web-padawan commented 11 months ago

Description

Unlike other custom column types, GridTreeColumn didn't support headerRenderer and footerRenderer. This is misaligned with the corresponding web component where only renderer function is not supported.

This PR adds missing APIs so it can be probably considered a bug fix (and therefore backported to 2.3)

Type of change

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0462893) 98.85% compared to head (68d9b2a) 98.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #194 +/- ## ========================================== + Coverage 98.85% 98.90% +0.04% ========================================== Files 25 26 +1 Lines 175 183 +8 Branches 20 20 ========================================== + Hits 173 181 +8 Misses 1 1 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/vaadin/react-components/pull/194/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/react-components/pull/194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `98.90% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vaadin-bot commented 11 months ago

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 2.3, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 5d7cf31ede6c615b1ebb3343f0cf5e22a843f314 error: could not apply 5d7cf31... fix: add GridTreeColumn header and footer renderers (#194) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".