vaadin / react-components

15 stars 4 forks source link

refactor: omit HTMLAttributes from non-visual component props #200

Closed web-padawan closed 11 months ago

web-padawan commented 11 months ago

Description

Fixes #192

Type of change

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fc85f95) 98.93% compared to head (0e85cc5) 98.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ======================================= Coverage 98.93% 98.93% ======================================= Files 26 26 Lines 187 187 Branches 21 21 ======================================= Hits 185 185 Misses 1 1 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/vaadin/react-components/pull/200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/react-components/pull/200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `98.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vaadin-bot commented 11 months ago

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 2.3, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick dd6ee7a4085f0d4d88ef8298f7713fd7350567a3 error: could not apply dd6ee7a... refactor: omit HTMLAttributes from non-visual component props (#200) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".