vaadin / router

Small and powerful client-side router for Web Components. Framework-agnostic.
https://vaadin.com/router
Apache License 2.0
413 stars 51 forks source link

Vaadin Router doesn't work with the PWA Starter Kit by default #317

Closed abdonrd closed 5 years ago

abdonrd commented 5 years ago

I create a new branch over the last PWA Starter Kit version: https://github.com/Polymer/pwa-starter-kit/compare/master...abdonrd:vaadin-router

It works during the development (npm start). But it doesn't work at after the build step (npm run build && npm run serve).

web-padawan commented 5 years ago

Looked into it and I think the problem is related to <base> tag set by prpl-server. Can be workarounded by using the following setting:

const router = new Router(outlet, {baseUrl: '/'});

Using that fixes the issue in PWA starter kit for me.

abdonrd commented 5 years ago

Awesome, thanks @web-padawan!