add option to enable native view transitions using the new View Transitions API

claytongulick commented 1 year ago

Description

This is a simple addition to optionally enable the new View Transition API

Fixes #841

Type of change

[ ] Bugfix
[X] Feature

Checklist

[X] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[X] I have added a description following the guideline.
[X] The issue is created in the corresponding repository and I have referenced it.
[X] I have added tests to ensure my change is effective and works as intended.
[X] New and existing tests are passing locally with my change.
[X] I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

[X] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

CLAassistant commented 1 year ago

All committers have signed the CLA.

lozandier commented 3 months ago

@claytongulick Have the historical reviewers of this repo such as @platosha and @jouni ever contacted you to review this CL to merge this in?

If not, it may make sense for a friendly ping to @vursen and other contributors to vaadin's Web component repository that had commits as recent as last week

jouni commented 3 months ago

Looks nice in general (didn't read the code in detail) 👍 Shame on us for not handling this PR in a timely manner.

Note, though, that Vaadin has recently moved over to using React Router (in Vaadin 24.4), so this enhancement/feature won't have an impact on new Vaadin apps. React Router has preliminary support for native view transitions: https://reactrouter.com/en/main/hooks/use-view-transition-state

vaadin / router