vaadin / sass-compiler

A Java Sass compiler implementation
53 stars 25 forks source link

remove logging.properties from vaadin-sass-compiler root package #258

Open vaadin-bot opened 10 years ago

vaadin-bot commented 10 years ago

Originally by kumm0307


Normally when no logging.properties given for an application, tomcat/conf/logging.properties defines logging in tomcat.

vaadin-sass-compiler breaks this behavior with an own logging.properties file. Tomcat loads this properties file for the whole application.

Tested on Tomcat 7.0.54

Slightly realated to #14000


Imported from https://dev.vaadin.com/ issue #14291

vaadin-bot commented 9 years ago

Originally by neeme


Also causes failure to deploy Vaadin application on JBoss EAP 6.0.0. The failure:

13:07:07,406 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-1) MSC000001: Failed to start service jboss.deployment.unit."myVaadinApp.war".POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.unit."myVaadinApp.war".POST_MODULE: JBAS018733: Failed to process phase POST_MODULE of deployment "myVaadinApp.war"
    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:123) [jboss-as-server-7.1.2.Final-redhat-1.jar:7.1.2.Final-redhat-1]
    at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
    at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_11]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_11]
    at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_11]
Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011555: Failed to configure logging using 'logging.properties' configuration file.
    at org.jboss.as.logging.LoggingConfigurationProcessor.deploy(LoggingConfigurationProcessor.java:125)
    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:116) [jboss-as-server-7.1.2.Final-redhat-1.jar:7.1.2.Final-redhat-1]
    ... 5 more
Caused by: java.lang.IllegalArgumentException: className is null
    at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:52) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.logmanager.config.HandlerConfigurationImpl.<init>(HandlerConfigurationImpl.java:54) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.logmanager.config.LogContextConfigurationImpl.addHandlerConfiguration(LogContextConfigurationImpl.java:138) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.logmanager.PropertyConfigurator.configureHandler(PropertyConfigurator.java:477) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:379) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:92) [jboss-logmanager-1.3.1.Final-redhat-1.jar:1.3.1.Final-redhat-1]
    at org.jboss.as.logging.LoggingConfigurationProcessor.deploy(LoggingConfigurationProcessor.java:122)
    ... 6 more
vaadin-bot commented 9 years ago

Originally by neeme


If you do not use SASS, just exclude the dependency in pom.xml:

    <dependency>
      <groupId>com.vaadin</groupId>
      <artifactId>vaadin-server</artifactId>
      <version>7.3.8</version>
      <exclusions>
        <exclusion>
          <groupId>com.vaadin</groupId>
          <artifactId>vaadin-sass-compiler</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
vaadin-bot commented 8 years ago

Originally by ryanhow


I am using SASS. And this appears to still be an issue in 7.6.4.

I can remove the dependency in the pom and put a local one in with the logging.properties removed.

The SASS compiler doesn't seem to change very often :)

But would still be good to remove it!

It took me a little while to track down why my logging had gone awol.

vaadin-bot commented 8 years ago

Originally by ryanhow


I believe this static block of code in ScssStylesheet.java is the culprit

    static {
        String logFile = System.getProperty("java.util.logging.config.file");
        if (logFile == null) {
            try {
                LogManager.getLogManager().readConfiguration(
                        ScssStylesheet.class
                                .getResourceAsStream("/logging.properties"));
            } catch (SecurityException e) {
                e.printStackTrace();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }