vaadin / spring

Spring integration for Vaadin
https://vaadin.com/start
174 stars 101 forks source link

chore: Upgrade to Spring Boot 2.7.7 #1046

Closed Artur- closed 1 year ago

Artur- commented 1 year ago

Spring Boot 2.5 and 2.6 are end of life

mcollovati commented 1 year ago

okhttp client version managed by spring conflicts with the one supported by the selenium version used in testbench 7.0.3 Upgrading testbench is not an option because base tests classes in Flow 9.0 uses 7.0.3 and there will be compilation errors. Solution may be adding an entry for com.squareup.okhttp3:okhttp:3.11.0 in dependency management section oif vaadin-spring-tests module.

mcollovati commented 1 year ago

@Artur- is it ok to pin okhttp3 in vaadin-spring-tests module?

mcollovati commented 1 year ago

@Artur- do you mind taking a look at the additional changes needed to upgrade to Spring Boot 2.7.7?

Artur- commented 1 year ago

Is the `spring.factories´ change the only one that explicitly makes it incompatible with earlier versions? If so, does it make sense to do it or just leave it use the deprecated variant "forever"?

mcollovati commented 1 year ago

Is the `spring.factories´ change the only one that explicitly makes it incompatible with earlier versions? If so, does it make sense to do it or just leave it use the deprecated variant "forever"?

It seems so, other changes are all related to our tests. I'll revert the spring.factories change

Artur- commented 1 year ago

👍 but I cannot approve my own PR

mcollovati commented 1 year ago

Thanks. I can approve it

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information