vaadin / spring

Spring integration for Vaadin
https://vaadin.com/start
174 stars 101 forks source link

fix: replace 'blocklist' and 'whitelist' with 'blocked' and 'allowed' #1077

Closed jouni closed 8 months ago

jouni commented 8 months ago

Fixes #645

Mark the existing methods as deprecated and introduce methods with new names.

Fall back to the old configuration properties if the new ones aren't used.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

jouni commented 8 months ago

I admit I did the changes almost “blindfolded”. I didn't run any tests or otherwise verify that it works. I hope someone can tell me how to do that, or do it for me 😄

mcollovati commented 8 months ago

The same changes should be applied also on Flow repository.

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Artur- commented 8 months ago

Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions

mcollovati commented 8 months ago

Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions

I'll create a PR in the flow repo

mcollovati commented 8 months ago

https://github.com/vaadin/flow/pull/18405

mcollovati commented 8 months ago

Tests failed because of issues with pnpm cache; browser console reported messages like

http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry
http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry

Cleaning pnpm cache before executing the validation fixed the job

mcollovati commented 8 months ago

@mshabarov LGTM, I don't know if you also want to take a look at it

mshabarov commented 8 months ago

We have to pick this into 19.1 branch as well.

vaadin-bot commented 8 months ago

Hi @jouni , this commit cannot be picked to 19.1 by this bot, can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 0af3dca8d3f416c8ff1e1c54ca76360fb6352405 error: could not apply 0af3dca... fix: replace 'blocklist' and 'whitelist' with 'blocked' and 'allowed' (#1077) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

jouni commented 8 months ago

Thanks for helping out with the finalization tasks!