Closed jouni closed 8 months ago
I admit I did the changes almost “blindfolded”. I didn't run any tests or otherwise verify that it works. I hope someone can tell me how to do that, or do it for me 😄
The same changes should be applied also on Flow repository.
Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions
Shouldn't this be done in https://github.com/vaadin/flow/tree/main/vaadin-spring ? This repository is for old Flow versions
I'll create a PR in the flow repo
Tests failed because of issues with pnpm cache; browser console reported messages like
http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry
http://ip-address:8888/parent-template 0:0 Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegist…-module" has already been used with this registry
Cleaning pnpm cache before executing the validation fixed the job
@mshabarov LGTM, I don't know if you also want to take a look at it
We have to pick this into 19.1 branch as well.
Hi @jouni , this commit cannot be picked to 19.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 0af3dca8d3f416c8ff1e1c54ca76360fb6352405
error: could not apply 0af3dca... fix: replace 'blocklist' and 'whitelist' with 'blocked' and 'allowed' (#1077)
hint: After resolving the conflicts, mark them with
hint: "git add/rm
Thanks for helping out with the finalization tasks!
Fixes #645
Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.