TouchKit dependency on vaadin-themes 7.3 breaks theme

[vaadin-bot]

Originally by @magi42

---

Including TouchKit as a dependency includes 7.3.x version of the vaadin-themes library in the widgetset-compile Ivy configuration. When compiling themes with the Eclipse plugin, it apparently uses the libraries in the widgetset-compile conf, and the vaadin-themes 7.3.x library, causing an invalid theme. The most significant symptom is that Grid breaks completely.

The problem does not occur if the theme is compiled with a build scropt with default and nodeploy confs, nor when compiled on-the-fly, as then the widgetset-compile libs are not available.

Excluding the vaadin-themes library in the Ivy dependency as follows solves the problem and TouchKit seems to work mostly OK.

<dependency org="com.vaadin.addon" name="vaadin-touchkit-agpl"
            rev="4.0.0" conf="default,widgetset-compile->default">
    <exclude org="com.vaadin" name="vaadin-themes"/>
</dependency>

The vaadin-themes is not included in the widgetset-compile conf if the "widgetset-compile->default" mapping is not given, but then again the TouchKit widgetset won't compile.

You can also solve the problem by having the newer vaadin-themes lib in the widgetset-compile conf as follows (it also pulls other needed newer Vaadin libs there):

<dependency org="com.vaadin"
            name="vaadin-themes"
            rev="&vaadin.version;"
            conf="nodeploy,default,widgetset-compile->default"/>

I guess this could also be considered an Eclipse plugin problem, as themes should probably be compiled with the nodeploy conf, not widgetset-compile, as it apparently does now.

[vaadin-bot]

Originally by @magi42

---

There's now also #16946 about this, as it's also an oddity in the Eclipse plugin that it apparently compiles themes with the widgetset-compile conf.

[vaadin-bot]

Originally by @magi42

---

Formatting typo.