vaadin / touchkit

TouchKit is a library of mobile components for Vaadin Framework
https://vaadin.com/touchkit
Other
11 stars 25 forks source link

TouchKit: ButtonCaption is not visible #409

Closed vaadin-bot closed 8 years ago

vaadin-bot commented 8 years ago

Originally by jonas.hahn


Button Caption is gone when using Touchkit with 7.5.6, with 7.4.6 it works.

!#java
    @Override
    protected void init(VaadinRequest vaadinRequest)
    {
        setContent(new Button("Hello"));
    }

    @WebServlet(urlPatterns # "/*", name"MyUIServlet", asyncSupported = true)
    @VaadinServletConfiguration(ui # MyUI.class, productionModefalse)
    public static class MyUIServlet extends TouchKitServlet
    {
    }

Imported from https://dev.vaadin.com/ issue #18979

vaadin-bot commented 8 years ago

Originally by jonas.hahn


nevermind I was using the valo theme, not the touchkit one

vaadin-bot commented 8 years ago

Originally by mvysny2


Does not work for me. It does not matter whether I set the theme to "valo", "touchkit" or "mytheme", the button's caption is not displayed properly (see screenshot). I am attaching the sample project - just run mvn clean install and deploy war. To fix the issue, set the theme to "valo" or "mytheme", comment out in MyAppWidgetset.gwt.xml, run mvn clean install and deploy war.

vaadin-bot commented 8 years ago

Originally by mvysny2


Attachment added: buggy_button_with_no_caption.png (2.1 KiB) buggy_button_with_no_caption.png https://trac-attachments.vaadin.com/trac/18979/buggy_button_with_no_caption.png

vaadin-bot commented 8 years ago

Originally by mvysny2


Attachment added: correct_button.png (1.5 KiB) correct_button.png https://trac-attachments.vaadin.com/trac/18979/correct_button.png

vaadin-bot commented 8 years ago

Originally by mvysny2


Attachment added: vaadin-widgetset-pokus.zip (56.4 KiB)

vaadin-bot commented 8 years ago

Originally by mvysny2


Please reopen this bug, this bug is reproducible via the project I attached to this bug. I have a suspection that the CSS auto-generated by the Vaading debug on-the-fly compiler works, while the CSS generated by the vaadin-maven-plugin suffers from the abovementioned bug. I am not sure if this is even possible, but this is what I have observed. Perhaps the touchkit somehow hacks into the on-the-fly generator, while it does not hack himself to the vaadin plugin?

vaadin-bot commented 8 years ago

Originally by mvysny2


This is reproducible with Vaadin 7.5.10 as well.