search

vaadin / touchkit

TouchKit is a library of mobile components for Vaadin Framework
https://vaadin.com/touchkit
Other
11 stars 25 forks source link

Update mobile-installation-parking-demo.asciidoc #423

Closed enver-haase closed 7 years ago

enver-haase commented 7 years ago

It's not useful using your mobile device and loading a web page from localhost.

This change is Reviewable

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

rogozinds commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

documentation/mobile-installation-parking-demo.asciidoc, line 38 at r1 (raw file):

using by issuing 'ipconfig' or 'ifconfig' Doesn't sound like proper English

documentation/mobile-installation-parking-demo.asciidoc, line 41 at r1 (raw file):

://:5678 with a mobile device or a WebKit-compatible browser, such as Safari or Chrome, to run the Parking Demo.   To use the approach in PR, you need have wifi or some emulator, and I guess we don't want to write all these complicated instructions.

Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

rogozinds commented 7 years ago

Closed, due to inactivity, review comments were not fixed for 1 months