search

vaadin / touchkit

TouchKit is a library of mobile components for Vaadin Framework
https://vaadin.com/touchkit
Other
11 stars 25 forks source link

Problems with touchkit 4.1 with firefox. #435 #439

Closed tullio0106 closed 3 years ago

tullio0106 commented 3 years ago

The #435 was closed but the problem is not yet solved. Could You reopen #435 or continue on this issue ? Tks Tullio

TatuLund commented 3 years ago

The Firefox issue will be fixed by https://github.com/vaadin/touchkit/pull/440

tullio0106 commented 3 years ago

Please what's the new version number in order to download it using maven ?

TatuLund commented 3 years ago

The fix of the Firefox issue is included in version 4.2.2 released yesterday.

tullio0106 commented 3 years ago

Unfortunately the situation is even wrost.

Now in every situation I get an error :

java.lang.NullPointerException

at com.vaadin.addon.touchkit.settings.TouchKitSettings$2.handleRequest(TouchKitSettings.java:308)

at com.vaadin.server.communication.SessionRequestHandler.handleRequest(SessionRequestHandler.java:63)

at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1438)

at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:380)

at com.vaadin.addon.touchkit.server.TouchKitServlet.service(TouchKitServlet.java:63)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)

at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)

at axioma.web.crm.ui.filter.CrmApplicationFilter.doFilter(CrmApplicationFilter.java:63)

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)

at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)

at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)

at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:526)

at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)

at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)

at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:678)

at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)

at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)

at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)

at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)

at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:861)

at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1579)

at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)

at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)

at java.lang.Thread.run(Thread.java:748)

Did I miss something ?

TatuLund commented 3 years ago

@tullio0106 This NPE is not related to previous Chrome and Firefox issues. The exception is thrown because request.getPathInfo() returned null. This sounds odd to me and requires further investigation. New ticket is needed about this and more info how to reproduce. The code where exception is however part of the new implementation for PWA, i.e. getPathInfo() is used to lookup the manfifest file of the PWA.

TatuLund commented 3 years ago

Actually there was the same bug in Touchkit 5, and it was fixed there https://github.com/parttio/touchkit/commit/d7b07dbd774b45599e7af7143d8b128ad144ac00

I will cherry pick the fix. For some reason I did not see this NPE in parking demo app.

TatuLund commented 3 years ago

I uploaded new version 4.2.3 to directly. Could you try that again.

tullio0106 commented 3 years ago

It seems to work correctly.

Tks for Your help.

Tullio