search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 7 forks source link

Restructure project to use several modules #100

Closed denis-anisimov closed 5 years ago

denis-anisimov commented 5 years ago

Part of https://github.com/vaadin/vaadin-button-flow/issues/92

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 5 years ago

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ButtonView.java#L146: Define a constant instead of duplicating this literal "Button " 3 times. rule
  2. MAJOR ButtonView.java#L194: Either re-interrupt this method or rethrow the "InterruptedException". rule
  3. MAJOR Button.java#L48: Remove this unused "disableListener" private field. rule
  4. MINOR ButtonView.java#L195: Use a logger to log this exception. rule