search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 8 forks source link

Button shortcut demo #123

Closed ujoni closed 5 years ago

ujoni commented 5 years ago

Demonstrates button shortcuts using the new Shortcut API available in V13.

This change is Reviewable

vaadin-bot commented 5 years ago

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ButtonView.java#L153: Define a constant instead of duplicating this literal "Button " 3 times. rule
  2. MAJOR ButtonView.java#L230: Either re-interrupt this method or rethrow the "InterruptedException". rule
  3. MINOR ButtonView.java#L231: Use a logger to log this exception. rule