search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 7 forks source link

Implement HasIcon constructor #125

Closed campbellbartlett closed 4 years ago

campbellbartlett commented 5 years ago

Implement constructors that use of a Vaadin Icon factory to allow easier construction of Buttons which have icons.

This change is Reviewable

campbellbartlett commented 5 years ago

a solution for this issue: https://github.com/vaadin/vaadin-button-flow/issues/110

campbellbartlett commented 5 years ago

Hi Dennis, Do you suggest adding a new interface to vaadin-button-flow (or somewhere else, I'm not sure where it should live) along the lines of: interface ComponentFactory { Component create(); } so we can update the iconFactory to: interface IconFactory() implements ComponentFactory { Icon create(); } this will allow us to update the button constructors that use iconFactory to use ComponentFactory instead?

tomivirkki commented 4 years ago

Closing as inactive. We're currently in the process of moving all the component repositories to a centralized monorepo and need to close all open pull requests. If this is still needed, please re-apply to https://github.com/vaadin/vaadin-flow-components