vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 7 forks source link

Re-enable button after disableonclick #126

Closed pleku closed 5 years ago

pleku commented 5 years ago

Because there is no diffstate feature in Flow, we need to force both the server and the client to update the value.

Fixes #115


This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 5 years ago

SonarQube analysis reported 4 issues

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ButtonView.java#L153: Define a constant instead of duplicating this literal "Button " 3 times. rule