search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 8 forks source link

Test for button setText fix #145

Closed shadikhani closed 4 years ago

shadikhani commented 4 years ago

Fixes vaadin/vaadin-button-flow#120

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Haprog commented 4 years ago

This only adds a test case, but doesn't actually fix the issue right? So the description should not say the word fix with the issue number (since GH would close the issue just by mergin this).

Also the CI build failed with:

java.lang.IllegalArgumentException: Unable to create an instance of 'com.vaadin.flow.component.button.tests.TemplateButtonPage'. The constructor threw an exception.
...
Caused by: java.lang.IllegalStateException: There is no element with id='text-button' in the template file 'frontend://template-button.html'. Cannot map it using @Id
...
ERROR com.vaadin.flow.router.InternalServerError - There was an exception while trying to navigate to 'template-button'
web-padawan commented 4 years ago

The proper fix and related test are added in https://github.com/vaadin/vaadin-button/pull/138. Closing.