search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 7 forks source link

Use getElement().appendChild instead of add in ButtonView to fix build #158

Closed mehdi-vaadin closed 4 years ago

mehdi-vaadin commented 4 years ago

Fixing snapshot build failure caused by making DemoView.add no-op

vaadin-bot commented 4 years ago

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ButtonView.java#L153: Define a constant instead of duplicating this literal "Button " 3 times. rule
  2. MAJOR ButtonView.java#L241: Either re-interrupt this method or rethrow the "InterruptedException". rule
  3. MAJOR ButtonView.java#L241: Either remove or fill this block of code. rule
mehdi-vaadin commented 4 years ago

Already fixed in the correct branch (2.1).