search

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component
https://vaadin.com/components/vaadin-button
Other
0 stars 8 forks source link

Depend on all WebJars explicitly to avoid version ranges in resulting jars. #75

Closed SomeoneToIgnore closed 6 years ago

SomeoneToIgnore commented 6 years ago

This change is Reviewable

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

SomeoneToIgnore commented 6 years ago

pom.xml, line 75 at r1 (raw file):

[WARNING] The POM for org.webjars.bowergithub.polymerelements:iron-flex-layout:jar:1.3.7 is missing, no dependency information available

I see this warning during the ordinary compilation. Is this the reason we exclude only this component?

Is there any safe way to try the release without actually publishing it? I've tried executing the plugin command myself, but failed.

SomeoneToIgnore commented 6 years ago

pom.xml, line 75 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…
Yes. That's the issue. When building this for the release this `WARNING` becomes `ERROR` and release fails. I don't remember which step it is. I'm not familiar with the release process in details. I remember that we have been releasing 4 days because of this error. So I'm pretty sure it will arise one more time. May be you can try do disable the very last step `deploy` (may be) in the TC release build and try to build and see. It might be that this error happens also only on staging server which is used to build before release. As I said: I don't remember details. You may ask Zhe. May be he recalls all issues related to that. But I recommend revert exclusion back. It shouldn't be a big issue and should be safe for the release.

Ok, done, but done in flow-component-base dependencyManagement section. Since every WebJar is mentioned there, it works. I've checked with mvn dependency:tree that the dependency does not occur in any of the component wrappers if not explicitly included in the pom.

Also to note: in each of the component wrapper projects you have flow-component-demo-helpers dependency https://github.com/vaadin/vaadin-button-flow/blob/master/pom.xml#L62 which has vaadin-lumo-theme dependency: https://github.com/vaadin/flow/blob/master/flow-components-parent/flow-component-demo-helpers/pom.xml#L48 that brings in iron-flex-layout transitive dependency.

This means that exclusions from test dependencies like https://github.com/vaadin/vaadin-button-flow/blob/master/pom.xml#L73 are pretty much redundant.

SomeoneToIgnore commented 6 years ago

pom.xml, line 38 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…
> ``` > iron-flex-layout > ``` I will block this change in every component for now. We need to be sure that this won't be block component release.

Done in flow-components-base

vaadin-bot commented 6 years ago

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR pom.xml#L85: Make this line start at column 9. rule
SomeoneToIgnore commented 6 years ago

pom.xml, line 75 at r1 (raw file):

So yeah, I don't know what's exactly going on there.

Me neither :)

I've checked all the projects for both branches: have run mvn clean install -DskipTests for each of the project, including flow-component-base and got no warning related to the missing pom for iron-flex-layout. They actually have no pom or missing words at all.

Also have checked random projects' TeamCity builds and they also seem to be fine. For instance, https://teamcity.vaadin.com/viewLog.html?buildId=39385&buildTypeId=Flow_Component_Button&tab=buildLog

has only one missing pom warning:

[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available

Does not seem related.